Overview
| Comment: | stub branch to fix issue in 220546828 where test goes to COMPLETED/DEAD while still in progress, then finally resolves to COMPLETED/PASS. Marked suspicious line of code -- see this commit for this |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | v1.64-bad-completed-dead |
| Files: | files | file ages | folders |
| SHA1: |
1903cf522f8a2a029fb602096a6d9019 |
| User & Date: | bjbarcla on 2017-07-27 15:44:24 |
| Other Links: | branch diff | manifest | tags |
Context
|
2017-07-27
| ||
| 16:20 | added another hint Closed-Leaf check-in: 3422b9b248 user: bjbarcla tags: v1.64-bad-completed-dead | |
| 15:44 | stub branch to fix issue in 220546828 where test goes to COMPLETED/DEAD while still in progress, then finally resolves to COMPLETED/PASS. Marked suspicious line of code -- see this commit for this check-in: 1903cf522f user: bjbarcla tags: v1.64-bad-completed-dead | |
|
2017-07-26
| ||
| 17:59 | Kill right-click menu check-in: bfd3170ff1 user: ritikaag tags: v1.64 | |
Changes
Modified db.scm from [13ba97e1b4] to [c96cc9703e].
| ︙ | ︙ | |||
1643 1644 1645 1646 1647 1648 1649 |
(min-incompleted-ids (map car incompleted)) ;; do 'em all
(all-ids (append min-incompleted-ids (map car oldlaunched))))
(if (> (length all-ids) 0)
(begin
(debug:print 0 *default-log-port* "WARNING: Marking test(s); " (string-intersperse (map conc all-ids) ", ") " as INCOMPLETE")
(for-each
(lambda (test-id)
| | > | 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 |
(min-incompleted-ids (map car incompleted)) ;; do 'em all
(all-ids (append min-incompleted-ids (map car oldlaunched))))
(if (> (length all-ids) 0)
(begin
(debug:print 0 *default-log-port* "WARNING: Marking test(s); " (string-intersperse (map conc all-ids) ", ") " as INCOMPLETE")
(for-each
(lambda (test-id)
(db:test-set-state-status dbstruct run-id test-id "COMPLETED" "DEAD" "Test failed to complete")) ;; fix for one aspect of Randy's ticket 1405717332 ;; TODO - fix problem where test goes to COMPLETED/DEAD while in progress, only later to go to COMPLETED/PASS. ref ticket 220546828
all-ids))))))))
;; ALL REPLACED BY THE BLOCK ABOVE
;;
;; (sqlite3:execute
;; db
;; (conc "UPDATE tests SET state='INCOMPLETE' WHERE run_id=? AND id IN ("
|
| ︙ | ︙ |