Megatest: Check-in [79525ab1fe]

Overview

Comment:	Completed generalized open db proc given area.
Downloads:	Tarball \| ZIP archive \| SQL archive
Timelines:	family \| ancestors \| descendants \| both \| v1.64-areas-dashboard
Files:	files \| file ages \| folders
SHA1:	79525ab1feebc97ab563a52a58be936513e78016
User & Date:	matt on 2017-08-09 23:24:22
Other Links:	branch diff \| manifest \| tags

Context

2017-08-13
23:07		Remove db-keys as global. Fixed typo in common:simple-setup Changed hh:get to hh:get-value and hh:get-subhash Ripped out guts of Run Areas (derived from Run Summary) and put in some stubs. Primed dashboard.scm to use areas based dbstucts. The rmt: calls have not being eliminated yet. Disabled ro db handling in dashboard. Added tab for pivot controls. Added couple missing bits for the db:dashboard-open-db multi-area support. Tested and working now. check-in: 9b83825da5 user: matt tags: v1.64-areas-dashboard
2017-08-09
23:24		Completed generalized open db proc given area. check-in: 79525ab1fe user: matt tags: v1.64-areas-dashboard
2017-08-08
22:21		Added hier-hash and nm server starting point check-in: 380af52b9c user: matt tags: v1.64-areas-dashboard

Changes

Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Modified common.scm from [4932effef8] to [bc7da1c8f9].

Modified dashboard-areas.scm from [2d0c769b51] to [686be016f0].

Modified db.scm from [4bb0d1ff30] to [ab18972644].

Modified mtut.scm from [de23d29c54] to [1a4e185888].

︙
961 962 963 964 965 966 967 ~~968~~ 969 970 971 ~~972 973~~ ~~974~~ 975 ~~976~~ 977 ~~978 979~~ ~~980~~ 981 982 983 984 985 986 987	961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991	- + - - + + + + + - - + - - + + + + + -	(define (common:false-on-exception thunk #!key (message #f)) (handle-exceptions exn (begin (if message (debug:print-info 0 default-log-port message)) #f) (thunk) )) ~~(define (common:file-exists? path-string)~~ (define (common:file-exists? path-string #!key (quiet-mode #f)) ;; this avoids stack dumps in the case where ;;;; TODO: catch permission denied exceptions and emit appropriate warnings, eg: system error while trying to access file: "/nfs/pdx/disks/icf_env_disk001/bjbarcla/gwa/issues/mtdev/randy-slow/reproduce/q... ~~(common:false-on-exception ~~(lambda () (file-exists? path-string))~~ ~~message:~~ (conc "Unable to access path: " path-string)~~ (common:false-on-exception (lambda () (file-exists? path-string)) message: (if quiet-mode #f (conc "Unable to access path: " path-string)))) )) ~~(define (common:directory-exists? path-string)~~ (define (common:directory-exists? path-string #!key (quiet-mode #f)) ;;;; TODO: catch permission denied exceptions and emit appropriate warnings, eg: system error while trying to access file: "/nfs/pdx/disks/icf_env_disk001/bjbarcla/gwa/issues/mtdev/randy-slow/reproduce/q... ~~(common:false-on-exception ~~(lambda () (directory-exists? path-string))~~ ~~message:~~ (conc "Unable to access path: " path-string)~~ (common:false-on-exception (lambda () (directory-exists? path-string)) message: (if quiet-mode #f (conc "Unable to access path: " path-string)))) )) ;; does the directory exist and do we have write access? ;; ;; returns the directory or #f ;; (define (common:directory-writable? path-string) (handle-exceptions
︙
1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111	1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144	+ + + + + + + + + + + + + + + + + + + + + + + + + + + + +	#f)))))) (at-home (or (equal? homehost currhost) (equal? homehost bestadrs)))) (set! home-host (cons homehost at-home)) (mutex-unlock! homehost-mutex) home-host)))) ;; get homehost info for a given area - but only if .homehost file already exists (define (common:minimal-get-homehost toppath) (let ((hh-file (conc toppath "/.homehost"))) (if (common:file-exists? hh-file quiet-mode: #t) (with-input-from-file hh-file read-line) #f))) ;; are we on the given host? (define (common:on-host? hh) (let* ((currhost (get-host-name)) (bestadrs (server:get-best-guess-address currhost))) (or (equal? hh currhost) (equal? hh bestadrs)))) ;; am I on the homehost? ;; (define (common:on-homehost?) (let ((hh (common:get-homehost))) (if hh (cdr hh) #f))) ;; minimal loading of megatest.config ;; (define (common:simple-setup toppath #!key (cfgf-ovrd #f)) (let* ((mtconfigf (or cfgf-ovrd "megatest.config")) (mtconfdat (find-and-read-config mtconfigf ;; environ-patt: "env-override" given-toppath: toppath ;; pathenvvar: "MT_RUN_AREA_HOME" )) (mtconf (if mtconfdat (car mtconfdat) #f))) (if mtconf (configf:section-var-set! mtconf "dyndat" "toppath" start-dir)) mtconfdat)) ;; do we honor the caches of the config files? ;; (define (common:use-cache?) (let ((res #t)) ;; priority by order of evaluation (if configdat ;; sillyness here. can't use setup/use-cache to know if we can use the cached files! (if (equal? (configf:lookup configdat "setup" "use-cache") "no")
︙

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	- +	;;====================================================================== ;; AREAS ;;====================================================================== (define (dashboard:areas-summary-updater commondat tabdat tb cell-lookup run-matrix) (dashboard:areas-do-update-rundat tabdat) ;; ) (dboard:areas-summary-control-panel-updater tabdat) (let* ((last-runs-update (dboard:tabdat-last-runs-update tabdat)) ~~(runs-dat (rmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f last-runs-update))~~ (runs-dat (mrmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f last-runs-update)) (runs-header (vector-ref runs-dat 0)) ;; 0 is header, 1 is list of records (runs (vector-ref runs-dat 1)) (run-id (dboard:tabdat-curr-run-id tabdat)) (runs-hash (dashboard:areas-get-runs-hash tabdat)) ;; (runs-hash (let ((ht (make-hash-table))) ;; (for-each (lambda (run) ;; (hash-table-set! ht (db:get-value-by-header run runs-header "id") run))
︙
127 128 129 130 131 132 133 ~~134 135~~ 136 137 ~~138~~ 139 ~~140~~ 141 142 143 144 145 146 ~~147~~ 148 149 150 151 152 153 154	127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154	- - + + - + - + - +	(debug:print-info 13 default-log-port "click-cb: obj="obj" lin="lin" col="col" status="status) ;; status is corrupted on Brandon's home machine. will have to wait until after shutdown to see if it is still broken in PDX SLES (let* ((toolpath (car (argv))) (key (conc lin ":" col)) (test-id (hash-table-ref/default cell-lookup key -1)) (run-id (dboard:tabdat-curr-run-id tabdat)) ~~(run-info (rmt:get-run-info run-id)) (target (rmt:get-target run-id))~~ (run-info (mrmt:get-run-info run-id)) (target (mrmt:get-target run-id)) (runname (db:get-value-by-header (db:get-rows run-info) (db:get-header run-info) "runname")) ~~(test-info (rmt:get-test-info-by-id run-id test-id))~~ (test-info (mrmt:get-test-info-by-id run-id test-id)) (test-name (db:test-get-testname test-info)) ~~(testpatt (let ((tlast (rmt:tasks-get-last target runname)))~~ (testpatt (let ((tlast (mrmt:tasks-get-last target runname))) (if tlast (let ((tpatt (tasks:task-get-testpatt tlast))) (if (member tpatt '("0" 0)) ;; known bad historical value - remove in 2017 "%" tpatt)) "%"))) ~~(item-path (db:test-get-item-path (rmt:get-test-info-by-id run-id test-id)))~~ (item-path (db:test-get-item-path (mrmt:get-test-info-by-id run-id test-id))) (item-test-path (conc test-name "/" (if (equal? item-path "") "%" item-path))) (status-chars (char-set->list (string->char-set status))) (testpanel-cmd (conc toolpath " -test " (dboard:tabdat-curr-run-id tabdat) "," test-id " &"))) (debug:print-info 13 default-log-port "status-chars=["status-chars"] status=["status"]") (cond
︙
230 231 232 233 234 235 236 ~~237 238 239~~ 240 241 242 243 244 245 246	230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246	- - - + + +	;; create a virtual table of all the tests ;; keypatts: ( (KEY1 "abc%def")(KEY2 "%") ) ;; (define (dboard:areas-update-rundat tabdat runnamepatt numruns testnamepatt keypatts) (let* ((access-mode (dboard:tabdat-access-mode tabdat)) (keys (dboard:tabdat-keys tabdat)) (last-runs-update (- (dboard:tabdat-last-runs-update tabdat) 2)) (allruns (rmt:get-runs runnamepatt numruns (dboard:tabdat-start-run-offset tabdat) keypatts)) ;;(allruns-tree (rmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f)) (allruns-tree (rmt:get-runs-by-patt keys "%" #f #f #f #f 0)) ;; last-runs-update));;'("id" "runname") (allruns (mrmt:get-runs runnamepatt numruns (dboard:tabdat-start-run-offset tabdat) keypatts)) ;;(allruns-tree (mrmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f)) (allruns-tree (mrmt:get-runs-by-patt keys "%" #f #f #f #f 0)) ;; last-runs-update));;'("id" "runname") (header (db:get-header allruns)) (runs (db:get-rows allruns)) ;; RA => Filtered as per runpatt selected (runs-tree (db:get-rows allruns-tree)) ;; RA => Returns complete list of runs (start-time (current-seconds)) (runs-hash (let ((ht (make-hash-table))) (for-each (lambda (run) (hash-table-set! ht (db:get-value-by-header run header "id") run))
︙
261 262 263 264 265 266 267 ~~268~~ 269 270 271 272 273 274 275	261 262 263 264 265 266 267 268 269 270 271 272 273 274 275	- +	(let loop ((run (car runs)) (tal (cdr runs)) (res '()) (maxtests 0)) (let* ((run-id (db:get-value-by-header run header "id")) (run-struct (hash-table-ref/default (dboard:tabdat-allruns-by-id tabdat) run-id #f)) ;; (last-update (if run-struct (dboard:rundat-last-update run-struct) 0)) ~~(key-vals (rmt:get-key-vals run-id))~~ (key-vals (mrmt:get-key-vals run-id)) (tests-ht (dboard:get-tests-for-run-duplicate tabdat run-id run testnamepatt key-vals)) ;; GET RID OF dboard:get-tests-dat - it is superceded by dboard:get-tests-for-run-duplicate ;; dboard:get-tests-for-run-duplicate - returns a hash table ;; (dboard:get-tests-dat tabdat run-id last-update)) (all-test-ids (hash-table-keys tests-ht)) (num-tests (length all-test-ids))) ;; (print "run-struct: " run-struct)
︙
337 338 339 340 341 342 343 ~~344~~ 345 346 347 348 349 350 351	337 338 339 340 341 342 343 344 345 346 347 348 349 350 351	- +	dbkeys) res)))) fres)))) (define (dashboard:areas-get-runs-hash tabdat) (let* ((access-mode (dboard:tabdat-access-mode tabdat)) (last-runs-update 0);;(dboard:tabdat-last-runs-update tabdat)) ~~(runs-dat (rmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f last-runs-update))~~ (runs-dat (mrmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f last-runs-update)) (runs-header (vector-ref runs-dat 0)) ;; 0 is header, 1 is list of records (runs (vector-ref runs-dat 1)) (run-id (dboard:tabdat-curr-run-id tabdat)) (runs-hash (let ((ht (make-hash-table))) (for-each (lambda (run) (hash-table-set! ht (db:get-value-by-header run runs-header "id") run)) runs) ht)))
︙
374 375 376 377 378 379 380 ~~381~~ 382 383 384 385 386 387 388	374 375 376 377 378 379 380 381 382 383 384 385 386 387 388	- +	(let* ((record-a (hash-table-ref runs-hash a)) (record-b (hash-table-ref runs-hash b)) (time-a (db:get-value-by-header record-a runs-header "event_time")) (time-b (db:get-value-by-header record-b runs-header "event_time"))) (< time-a time-b))))) (changed #f) (last-runs-update (dboard:tabdat-last-runs-update tabdat)) ~~(runs-dat (rmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f 0)) ;; last-runs-update))~~ (runs-dat (mrmt:get-runs-by-patt (dboard:tabdat-keys tabdat) "%" #f #f #f #f 0)) ;; last-runs-update)) (runs-header (vector-ref runs-dat 0)) ;; 0 is header, 1 is list of records (runs (vector-ref runs-dat 1)) (new-run-ids (map (lambda (run) (db:get-value-by-header run runs-header "id")) runs)) (areas (configf:get-section configdat "areas"))) (dboard:tabdat-last-runs-update-set! tabdat (- (current-seconds) 2))
︙
417 418 419 420 421 422 423 ~~424~~ 425 426 427 428 429 430 431	417 418 419 420 421 422 423 424 425 426 427 428 429 430 431	- +	(hash-table-set! (dboard:tabdat-path-run-ids tabdat) run-path run-id) ;; (set! colnum (+ colnum 1)) )))) (append new-run-ids run-ids)))) ;; for-each run-id (define (dashboard:areas-run-id->tests-mindat run-id tabdat runs-hash) (let* ((run (hash-table-ref/default runs-hash run-id #f)) ~~(key-vals (rmt:get-key-vals run-id))~~ (key-vals (mrmt:get-key-vals run-id)) (testnamepatt (or (dboard:tabdat-test-patts tabdat) "%/%")) (tests-ht (dboard:get-tests-for-run-duplicate tabdat run-id run testnamepatt key-vals)) (tests-dat (dashboard:tests-ht->tests-dat tests-ht)) (tests-mindat (dcommon:minimize-test-data tests-dat))) ;; reduces data for display (dboard:tabdat-last-runs-update-set! tabdat (- (current-seconds) 2)) (hash-table-set! (dboard:tabdat-last-test-dat tabdat) run-id tests-dat) (hash-table-set! (dboard:tabdat-run-update-times tabdat) run-id (- (current-seconds) 10))
︙
501 502 503 504 505 506 507 ~~508~~ 509 510 511 512 513 514 515	501 502 503 504 505 506 507 508 509 510 511 512 513 514 515	- +	(lambda (obj) (dcommon:examine-xterm run-id test-id))) (iup:menu-item (conc "Kill " item-test-path) #:action (lambda (obj) ~~;; (rmt:test-set-state-status-by-id run-id test-id "KILLREQ" #f #f)~~ ;; (mrmt:test-set-state-status-by-id run-id test-id "KILLREQ" #f #f) (common:run-a-command (conc "megatest -set-state-status KILLREQ,n/a -target " target " -runname " runname " -testpatt " item-test-path " -state RUNNING,REMOTEHOSTSTART,LAUNCHED,NOT_STARTED"))))
︙
574 575 576 577 578 579 580 ~~581~~ 582 583 584 585 586 587 588	574 575 576 577 578 579 580 581 582 583 584 585 586 587 588	- +	" -runname " runname " -testpatt " item-test-path " -preclean -clean-cache")))) (iup:menu-item (conc "Kill " item-test-path) #:action (lambda (obj) ~~;; (rmt:test-set-state-status-by-id run-id test-id "KILLREQ" #f #f)~~ ;; (mrmt:test-set-state-status-by-id run-id test-id "KILLREQ" #f #f) (common:run-a-command (conc "megatest -set-state-status KILLREQ,n/a -target " target " -runname " runname " -testpatt " item-test-path " -state RUNNING,REMOTEHOSTSTART,LAUNCHED")))) (iup:menu-item (conc "Delete data : " item-test-path)
︙
690 691 692 693 694 695 696 ~~697~~ 698 699 ~~700~~ 701 702 703 704 705 706 707	690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707	- + - +	(mode (dboard:tabdat-runs-summary-mode tabdat))) (when (and source-runname-label dest-runname-label) (case mode ((xor-two-runs xor-two-runs-hide-clean) (let* ((curr-run-id (dboard:tabdat-curr-run-id tabdat)) (prev-run-id (dboard:tabdat-prev-run-id tabdat)) (curr-runname (if curr-run-id ~~(rmt:get-run-name-from-id curr-run-id)~~ (mrmt:get-run-name-from-id curr-run-id) "None")) (prev-runname (if prev-run-id ~~(rmt:get-run-name-from-id prev-run-id)~~ (mrmt:get-run-name-from-id prev-run-id) "None"))) (iup:attribute-set! source-runname-label "TITLE" (conc " SRC: "prev-runname" ")) (iup:attribute-set! dest-runname-label "TITLE" (conc "DEST: "curr-runname" ")))) (else (iup:attribute-set! source-runname-label "TITLE" "") (iup:attribute-set! dest-runname-label "TITLE" ""))))))
︙

︙
47 48 49 50 51 52 53 54 55 56 57 58 59 60	47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63	+ + +	(tmpdb #f) (dbstack #f) ;; stack for tmp db handles, do not initialize with a stack (mtdb #f) (refndb #f) (homehost #f) ;; not used yet (on-homehost #f) ;; not used yet (read-only #f) (configdat #f) (keys #f) (area-path #f) ) ;; goal is to converge on one struct for an area but for now it is too confusing ;; record for keeping state,status and count for doing roll-ups in ;; iterated tests ;; (defstruct dbr:counts
︙
71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86	74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113	+ + + + + + + + + + + + + + + + + + + + + + + + - +	;; tmpdb - local to this machine, all reads to this ;; mtdb - full db from mtrah ;; no-sync-db - ;; on-homehost - enable reading from other users /tmp db if files are readable ;; ;; areas is hash of areas => dbstruct, the dashboard-open-db will register the dbstruct in that hash ;; ;; NOTE: This returns the tmpdb path/handle pair. ;; NOTE: This does do a sync (the db:open-db proc only does an initial sync if called with do-sync: #t ;; NOTE: Longer term consider replacing db:open-db with this ;; (define (db:dashboard-open-db areas area-path) ;; 0. check for already existing dbstruct in areas hash, return it if found ;; 1. do minimal read of megatest.config, store configdat, keys in dbstruct ;; 2. get homehost ;; 3. create /tmp db area (if needed) ;; 4. sync data to /tmp db (or update if exists) ;; 5. return dbstruct (if (hash-table-exists? areas area-path) (hash-table-ref areas area-path) (if (common:file-exists? (conc area-path "/megatest.config") quiet-mode: #t) (let* ((homehost (common:minimal-get-homehost toppath)) (on-hh (common:on-host? homehost)) (mtconfig (common:simple-setup area-path)) ;; returns ( configdat toppath configfile configf-name ) (dbstruct (make-dbr:dbstruct area-path: area-path homehost: homehost configdat: (car mtconfig))) (tmpdb (db:open-db dbstruct area-path: area-path do-sync: #t))) tmpdb) (begin (debug:print-info 0 default-log-port "attempt to open megatest.db in " area-path " but no megatest.config found.") ~~#f)~~ #f)))) ;; sync all the areas listed in area-paths ;; (define (db:dashboard-sync-dbs areas area-paths) #f) ;; close all area db's
︙
323 324 325 326 327 328 329 ~~330~~ 331 332 333 ~~334~~ 335 336 337 ~~338~~ 339 ~~340~~ 341 342 343 344 345 346 347	350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375	- + + - + - + - +	;; (dbr:dbstruct-olddb-set! dbstruct olddb) ;; ;;; (mutex-unlock! rundb-mutex) ;;; why did we need a mutex on opening db's? ;; (db:sync-tables db:sync-tests-only megatest-db db) ;; db)) ;; This routine creates the db if not already present. It is only called if the db is not already opened ;; ~~(define (db:open-db dbstruct #!key (areapath #f)(do-sync #t)) ;; TODO: actually use areapath~~ (define (db:open-db dbstruct #!key (area-path #f)(do-sync #t)) ;; TODO: actually use areapath (let ((tmpdb-stack (dbr:dbstruct-dbstack dbstruct))) ;; RA => Returns the first reference in dbstruct (if (stack? tmpdb-stack) (db:get-db tmpdb-stack) ;; get previously opened db (will create new db handle if all in the stack are already used (let* ((toppath (or area-path (dbr:dbstruct-area-path dbstruct) toppath)) ~~~~(let* (~~(dbpath (db:dbfile-path )) ;; path to tmp db area~~ (dbpath (db:dbfile-path )) ;; path to tmp db area (dbexists (common:file-exists? dbpath)) (tmpdbfname (conc dbpath "/megatest.db")) (dbfexists (common:file-exists? tmpdbfname)) ;; (conc dbpath "/megatest.db"))) ~~(mtdbexists (common:file-exists? (conc toppath "/megatest.db")))~~ (mtdbexists (common:file-exists? (conc toppath "/megatest.db"))) ~~(mtdb (db:open-megatest-db))~~ (mtdb (db:open-megatest-db path: area-path)) (mtdbpath (db:dbdat-get-path mtdb)) (tmpdb (db:open-megatest-db path: dbpath)) ;; lock-create-open dbpath db:initialize-main-db)) (refndb (db:open-megatest-db path: dbpath name: "megatest_ref.db")) (write-access (file-write-access? mtdbpath)) (mtdbmodtime (if mtdbexists (common:lazy-sqlite-db-modification-time mtdbpath) #f)) (tmpdbmodtime (if dbfexists (common:lazy-sqlite-db-modification-time tmpdbfname) #f)) (modtimedelta (and mtdbmodtime tmpdbmodtime (- mtdbmodtime tmpdbmodtime))))
︙